Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update Swift SDK dependency to 0.22.0 #3155

Closed
wants to merge 3 commits into from

Conversation

atierian
Copy link
Member

@atierian atierian commented Aug 15, 2023

Issue #

Description

Tracking Issues

  • A recent change in ClientRuntime made the SdkHttpRequest headers property get only. This is problematic, as we're setting those today in PinpointRequestRegistry and UserAgentSuffixAppender

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian mentioned this pull request Aug 15, 2023
9 tasks
@atierian atierian temporarily deployed to Fortify August 15, 2023 17:06 — with GitHub Actions Inactive
@atierian
Copy link
Member Author

@atierian atierian closed this Oct 11, 2023
@atierian atierian deleted the swift-sdk-0220 branch October 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant